Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ansible requirements, remove become for localhost delegated tasks #188

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

codyro
Copy link
Collaborator

@codyro codyro commented Oct 12, 2023

Ansible did not support notify in blocks until version 2.11.0. To avoid having users receive an unfriendly error (#177), let them know that the version of Ansible they're running is too old.

Changes

- Adds assertion to gracefully fail instead of an error (ref LemmyNet#177)
- Add to README
@codyro codyro changed the title Update ansible requirements Update ansible requirements, remove become for localhost delegated tasks Oct 12, 2023
@codyro codyro linked an issue Oct 12, 2023 that may be closed by this pull request
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@codyro codyro added this to the 1.2.1 milestone Oct 13, 2023
Copy link
Collaborator

@ticoombs ticoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dessalines dessalines merged commit 300a261 into LemmyNet:main Oct 13, 2023
usr3 pushed a commit to usr3/futurology-lemmy that referenced this pull request Dec 23, 2023
…tasks (LemmyNet#188)

* Add ansible-core >= 2.11.0 requirement
- Adds assertion to gracefully fail instead of an error (ref LemmyNet#177)
- Add to README

* Remove `become` on `localhost` to `lemmy-almalinux.yml` playbook
- Refs LemmyNet#178

* Adjust Ansible -> ansible-core
- Add `become: false` to assertion in `lemmy.yml`

* Adjust README verbiage

* Apparently I really want it to be 2.10.0
snowe2010 pushed a commit to programming-dot-dev/lemmy-ansible that referenced this pull request Jan 30, 2024
…tasks (LemmyNet#188)

* Add ansible-core >= 2.11.0 requirement
- Adds assertion to gracefully fail instead of an error (ref LemmyNet#177)
- Add to README

* Remove `become` on `localhost` to `lemmy-almalinux.yml` playbook
- Refs LemmyNet#178

* Adjust Ansible -> ansible-core
- Add `become: false` to assertion in `lemmy.yml`

* Adjust README verbiage

* Apparently I really want it to be 2.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR! 'notify' is not a valid attribute for a Block
3 participants