-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ansible requirements, remove become
for localhost delegated tasks
#188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds assertion to gracefully fail instead of an error (ref LemmyNet#177) - Add to README
codyro
changed the title
Update ansible requirements
Update ansible requirements, remove Oct 12, 2023
become
for localhost delegated tasks
- Add `become: false` to assertion in `lemmy.yml`
dessalines
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
ticoombs
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
usr3
pushed a commit
to usr3/futurology-lemmy
that referenced
this pull request
Dec 23, 2023
…tasks (LemmyNet#188) * Add ansible-core >= 2.11.0 requirement - Adds assertion to gracefully fail instead of an error (ref LemmyNet#177) - Add to README * Remove `become` on `localhost` to `lemmy-almalinux.yml` playbook - Refs LemmyNet#178 * Adjust Ansible -> ansible-core - Add `become: false` to assertion in `lemmy.yml` * Adjust README verbiage * Apparently I really want it to be 2.10.0
snowe2010
pushed a commit
to programming-dot-dev/lemmy-ansible
that referenced
this pull request
Jan 30, 2024
…tasks (LemmyNet#188) * Add ansible-core >= 2.11.0 requirement - Adds assertion to gracefully fail instead of an error (ref LemmyNet#177) - Add to README * Remove `become` on `localhost` to `lemmy-almalinux.yml` playbook - Refs LemmyNet#178 * Adjust Ansible -> ansible-core - Add `become: false` to assertion in `lemmy.yml` * Adjust README verbiage * Apparently I really want it to be 2.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible did not support
notify
inblock
s until version2.11.0
. To avoid having users receive an unfriendly error (#177), let them know that the version of Ansible they're running is too old.Changes
README.md
to addansible-core >= 2.11.0
requirementlemmy.yml
&lemmy-almalinux.yml
playbooks to verify the Ansible version before continuing to run. This will help in instances such as the one in ERROR! 'notify' is not a valid attribute for a Block #177become: false
to tasks running onlocalhost
to thelemmy-almalinux.yml
(brings in-line withlemmy.yml
. Refs fix: force no become on localhost (fixes: #178) #185)