Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Security.txt #1408

Merged
merged 8 commits into from
Jun 29, 2023
Merged

Add Security.txt #1408

merged 8 commits into from
Jun 29, 2023

Conversation

rcmaehl
Copy link
Contributor

@rcmaehl rcmaehl commented Jun 20, 2023

@rcmaehl
Copy link
Contributor Author

rcmaehl commented Jun 20, 2023

[warn] src/server/index.tsx
[warn] Code style issues found in the above file. Forgot to run Prettier?

Attempted to run a prettier using a few different online tools and all resulted in no changes to the code. Not sure what it's complaining about.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Husky didn't get set up properly, so its failing lint. You'll need to run prettier manually.

@@ -22,6 +23,7 @@ if (!process.env["LEMMY_UI_DISABLE_CSP"] && !process.env["LEMMY_UI_DEBUG"]) {
server.use(setDefaultCsp);
}

server.get("/.well-known/security.txt", SecurityHandler);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to make sure this gets handled by nginx too.

@rcmaehl
Copy link
Contributor Author

rcmaehl commented Jun 22, 2023

Not sure why it requested a review from alectrocute but okay.

@SleeplessOne1917
Copy link
Member

@rcmaehl The actual changes seem good to me. @dessalines should merging this be held off until the nginx configs are updated to handle it?

@rcmaehl rcmaehl requested a review from jsit as a code owner June 28, 2023 17:18
@rcmaehl
Copy link
Contributor Author

rcmaehl commented Jun 28, 2023

Ah so it requests a review every time I update the branch. New to big pull requests...

@dessalines
Copy link
Member

@SleeplessOne1917 We can merge this before those nginx configs are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants