Add back support for Env vars

[Nutomic]

Was broken by #1433. We should be able to support env vars again with the same behaviour as before, by following the example in softprops/envy#55 (comment).

Edit: The solution is not going to work, because of another Envy issue: softprops/envy#26

$ LEMMY_CAPTCHA__ENABLED=false LEMMY_CAPTCHA__DIFFICULTY=easy cargo run
Finished dev [unoptimized] target(s) in 0.15s
Running `target/debug/lemmy_server`
thread 'main' panicked at 'invalid type: string "false", expected a boolean'

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Nutomic]

I tried another crate, envconfig to implement this, but its missing many required features. All other related libraries I found are really small and unmaintained. So it looks like we would have to reimplement this functionality from scratch, which we dont have time for. This means configuration with env vars will not be supported in the next version, and probably not for a long time (except for a few specific vars which we can handle manually).

[gabe565]

I'm creating a Helm chart for Lemmy Kubernetes deployments, and envs would be useful for setting default chart values. Would you consider reopening this issue?

[dessalines]

I think it'd be too much work. Is there any reason you can't use a lemmy.hjson file?

[gabe565]

Got it! Essentially, I would like to generate some of the config values, but using hjson might make it a bit more challenging. I can still generate the file, though, since regular JSON is valid hjson, it will just introduce some additional complexity and make things less dynamic.

For instance, if the user configures my Helm chart to deploy Pictrs, I could automatically generate an API key and store it as a Secret. Then, both pictrs and lemmy could use that secret to set the env. When using a config file, I'll need to generate and set the value explicitly in JSON. It makes the configuration less dynamic, but it's not a major issue.

I'll see if there's an elegant way for me to generate the hjson file. Thank you! 🙂