Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new release #517

Closed
paztis opened this issue Aug 7, 2019 · 15 comments
Closed

new release #517

paztis opened this issue Aug 7, 2019 · 15 comments

Comments

@paztis
Copy link

paztis commented Aug 7, 2019

Hi all

Dependencies versions have been updated 1 year ago, but last xml2js release is still 2 years old
Is it possible to release it again ?

In last npm release, xmlbuilder is in version ~9.0.1
In last git package.json, xmlbuilder is in version ~10.0.0
and more xmlbuilder is now in version 13.0.2

xmlbuilder adds now the ability to format attributes on multiple lines that is missing in xml2js
Is it possible to increase the version and republish it ?

Thanks

@paztis
Copy link
Author

paztis commented Aug 7, 2019

or better, to let the ability in the Builder contructor to pass another instance of xmlbuilder.
Like this people like me can pass a more recent version of xmlbuilder without forcing you to update your code. I can create a PR for this if needed

@knoxcard
Copy link

Exactly...#524

@knoxcard
Copy link

knoxcard commented Aug 30, 2019

@paztis - That would be pretty sweet actually!
Just drawing out the code to illustrate to others...

const xml2js = require('xml2js');

// holy moly!  - wouldn't need hard coded dependencies in package.json
xml2js.sax(require('sax'))
xml2js.xmlbuilder(require('xmlbuilder'))

// or something like...
xml2js.dependencies.push(require('sax'))
xml2js.dependencies.push(require('xmlbuilder'))

const xml = '<root>Hello world!</root>'
xml2js.parseString(xml, function (err, result) {
    console.log(result.root); // Output: Hello world!
});

@Leonidas-from-XIV

@Leonidas-from-XIV
Copy link
Owner

I'll try to make a release this weekend.

@Leonidas-from-XIV
Copy link
Owner

Just published 0.4.20.

@tomhughes
Copy link
Contributor

Could you tag it on github please?

@Leonidas-from-XIV
Copy link
Owner

Ah yes, forgot to push the commit. There you go, it is tagged now.

@paztis
Copy link
Author

paztis commented Sep 1, 2019

Version of xmlbuilder is not increased to ~13.0.0 in your release ?

@Leonidas-from-XIV
Copy link
Owner

Leonidas-from-XIV commented Sep 1, 2019 via email

@paztis
Copy link
Author

paztis commented Sep 1, 2019

I don't know if multiline attributes formatting is available in 10.0.0.
Will check it tomorrow

@paztis
Copy link
Author

paztis commented Sep 1, 2019

No it is available since 12.0.1 : oozcitak/xmlbuilder-js@c92ba3e

It means my defect is still opened, as there's still no way to pass an upper version.

@paztis
Copy link
Author

paztis commented Sep 1, 2019

It is explain in the first post of this topic. That was the reason I ask to increase the dependency version of xmlbuilder.

Currently It is not possible to format a xml with attributes on multiple lines. As I work on big xml with long attributes names, result is not readable.

Xmlbuilder allows since the version 12 to pass a "width" option to limit the width or the lines.
As you just pass down the option to xmlbuilder, it works automatically on your module if we're able to move to version 12.0.1 at minimum.

@Leonidas-from-XIV
Copy link
Owner

#528

@Leonidas-from-XIV
Copy link
Owner

Released as 0.4.21 just now.

@paztis
Copy link
Author

paztis commented Sep 2, 2019

Perfect thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants