-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please release xml2js 0.4.24 including the security fix of 0.5.0 - important #671
Comments
I don't think I can do that because instead of keeping some packages at old versions (which can be overridden using npm and depending on the package might work) it would potentially break every single dependency. So the best I can suggest is to either override it (if possible, given some changes are indeed backwards incompatible) or fork parse-bmfont-xml and update the code. |
@Leonidas-from-XIV I used an override in package.json, which is working just fine:
|
Yes, in this case it works but that's not true of all the packages that depend on xml2js unfortunately. |
Fixed in mattdesl/parse-bmfont-xml#4 |
@Leonidas-from-XIV There has been a stream of issues coming in mainly from JIMP users due to the transient dependency on xml2js via
^0.4
which doesn't bump up to the fixed version 0.5.Please see mattdesl/parse-bmfont-xml#4 and mattdesl/parse-bmfont-xml#6 and jimp-dev/jimp#1223 for more details.
The problem is that @mattdesl the developer of parse-bmfont-xml is unreachable.
So a quick fix to these problems would be for you to release a
xml2js@0.4.24
version (with the same content as 0.5.0) which would then be picked up when reinstalling JIMP via transient parse-bmfont-xml.Thanks a lot!
PS: I take note of the discussion following your observation of a possible breaking change when going from 0.4.23 to 0.5.0 #667 (comment)
The text was updated successfully, but these errors were encountered: