simplify encodeLtgt api

Level · Apr 17, 2015 · 24f3817 · 24f3817
1 parent e4080a4
commit 24f3817
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -31,9 +31,9 @@ var codec = new Codec(db.options);
 
   Encode `batch` ops with given `opts`.
 
-### #encodeLtgt(ltgt[, opts])
+### #encodeLtgt(ltgt)
 
-  Encode the ltgt values of option object `ltgt` with given `opts`.
+  Encode the ltgt values of option object `ltgt`.
 
 ### #decodeKey(key[, opts])
 

diff --git a/index.js b/index.js
@@ -61,12 +61,12 @@ Codec.prototype.encodeBatch = function(ops, opts){
 
 var ltgtKeys = ['lt', 'gt', 'lte', 'gte', 'start', 'end'];
 
-Codec.prototype.encodeLtgt = function(ltgt, opts){
+Codec.prototype.encodeLtgt = function(ltgt){
   var self = this;
   var ret = {};
   Object.keys(ltgt).forEach(function(key){
     ret[key] = ltgtKeys.indexOf(key) > -1
-      ? self.encodeKey(ltgt[key], opts)
+      ? self.encodeKey(ltgt[key], ltgt)
       : ltgt[key]
   });
   return ret;

diff --git a/test/ltgt.js b/test/ltgt.js
@@ -2,17 +2,22 @@ var test = require('tape');
 var Codec = require('..');
 
 test('encode ltgt', function(t){
+  var codec = new Codec({ keyEncoding: 'hex' });
+
   var ltgt = {
     start: '686579',
     lte: '686579'
   };
-  var codec = new Codec({ keyEncoding: 'hex' });
-
   var encoded = codec.encodeLtgt(ltgt);
   t.equal(encoded.start.toString(), 'hey');
   t.equal(encoded.lte.toString(), 'hey');
 
-  var encoded = codec.encodeLtgt(ltgt, { keyEncoding: 'json' });
+  ltgt = {
+    start: '686579',
+    lte: '686579',
+    keyEncoding: 'json'
+  };
+  encoded = codec.encodeLtgt(ltgt);
   t.equal(encoded.start, '"686579"');
   t.equal(encoded.lte, '"686579"');