Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing people and metadata #20

Closed
14 tasks done
vweevers opened this issue Jun 8, 2018 · 13 comments
Closed
14 tasks done

Add missing people and metadata #20

vweevers opened this issue Jun 8, 2018 · 13 comments
Assignees

Comments

@vweevers
Copy link
Member

vweevers commented Jun 8, 2018

Ref Level/level-js#141.

  • hij1nx twitter => hxoht twitter
  • add substack
  • add Ryan Ramage
  • add James Kyburz
  • add Yoshua Wuyts
  • add Calvin Metcalf
  • add Nicholas Westlake
  • add Bryce Baril
@vweevers
Copy link
Member Author

vweevers commented Jun 8, 2018

> level-js@3.0.0-rc1 remark
> remark README.md CONTRIBUTORS.md -o

CONTRIBUTORS.md
  1:1  warning  no social profile for @shama             social           remark-gh-contributors
  1:1  warning  no social profile for @vweevers          social           remark-gh-contributors
  1:1  warning  no social profile for @calvinmetcalf     social           remark-gh-contributors
  1:1  warning  no social profile for @substack          social           remark-gh-contributors
  1:1  warning  no social profile for @ralphtheninja     social           remark-gh-contributors
  1:1  warning  no social profile for @nrw               social           remark-gh-contributors
  1:1  warning  no social profile for @ryanramage        social           remark-gh-contributors
  1:1  warning  no social profile for @qs44              social           remark-gh-contributors
  1:1  warning  no social profile for @JamesKyburz       social           remark-gh-contributors
  1:1  warning  no social profile for @brycebaril        social           remark-gh-contributors
  1:1  warning  no social profile for @yoshuawuyts       social           remark-gh-contributors
  1:1  warning  no social profile for @nolanlawson       social           remark-gh-contributors

@ralphtheninja ralphtheninja self-assigned this Jun 9, 2018
@vweevers
Copy link
Member Author

vweevers commented Jun 9, 2018

When contributors are sourced from git rather than the Github API, we have a lot more missing metadata. Current output (for level-js):


Contributors

Name GitHub Social
Vincent Weevers @vweevers @vweevers@twitter
Maxwell ogden @maxogden @maxogden@twitter
Lars-Magnus Skog @ralphtheninja @ralph@social.weho.st
Max Ogden
Rod Vagg
Nolan Lawson
qs44
Julian Gruber @juliangruber @juliangruber@twitter
Dominic Tarr @dominictarr @dominictarr@twitter
Matteo Collina
Kyle Robinson Young @shama @shamakry@twitter
Mathias Buus @mafintosh @mafintosh@twitter
James Halliday
Ryan Ramage
James Kyburz
Yoshua Wuyts
Calvin Metcalf
Nicholas Westlake
Bryce Baril

@vweevers
Copy link
Member Author

vweevers commented Jun 9, 2018

Sec, let me run it against your update-contributors branch @ralphtheninja.

@vweevers
Copy link
Member Author

vweevers commented Jun 9, 2018

Updated.

@ralphtheninja
Copy link
Member

Noticed there are two Max. One 'Maxwell ogden' and one 'Max Ogden'. Updated.

@vweevers
Copy link
Member Author

vweevers commented Jun 9, 2018

Noticed there are two Max. One 'Maxwell ogden' and one 'Max Ogden'

That's because max shows up with two email adresses in git history. So do others.

@vweevers
Copy link
Member Author

OK, if I also match by name (which I prefer to avoid but I also want to move on) it's better:

Name GitHub Social
Vincent Weevers @vweevers @vweevers@twitter
Max Ogden @maxogden @maxogden@twitter
Lars-Magnus Skog @ralphtheninja @ralph@social.weho.st
Rod Vagg @rvagg @rvagg@twitter
Nolan Lawson @nolanlawson @nolan@toot.cafe
Josh @qs44
Julian Gruber @juliangruber @juliangruber@twitter
Dominic Tarr @dominictarr @dominictarr@twitter
Matteo Collina @mcollina @matteocollina@twitter
Kyle Robinson Young @shama @shamakry@twitter
Mathias Buus @mafintosh @mafintosh@twitter
James Halliday
Ryan Ramage
James Kyburz
Yoshua Wuyts
Calvin Metcalf
Nicholas Westlake
Bryce Baril

@vweevers vweevers reopened this Jun 10, 2018
@ralphtheninja
Copy link
Member

OK, if I also match by name (which I prefer to avoid but I also want to move on) it's better:

People will change their emails so we should probably do so even if it hurts in the programmer soul. I'll update the rest of the names today.

@ralphtheninja
Copy link
Member

@vweevers There's a bug in generating the mastodon urls, the nicks in the tail of the url are missing a @

@vweevers
Copy link
Member Author

even if it hurts in the programmer soul

🤣 it does

@ralphtheninja
Copy link
Member

@vweevers
Copy link
Member Author

Fixed.

@ralphtheninja
Copy link
Member

@vweevers This one can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants