Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Test illegal and stringified key types #139

Merged
merged 3 commits into from
Jun 3, 2018
Merged

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Jun 2, 2018

Closes #132, closes #133.

@vweevers vweevers requested a review from ralphtheninja June 2, 2018 14:26
@@ -8,7 +8,6 @@ var AbstractLevelDOWN = require('abstract-leveldown').AbstractLevelDOWN
var inherits = require('inherits')
var Iterator = require('./iterator')
var mixedToBuffer = require('./util/mixed-to-buffer')
var isDataCloneError = require('./util/is-data-clone-error')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this file can be removed and the function moved into test/structured-clone-test.js?

@vweevers vweevers merged commit 89c8034 into master Jun 3, 2018
@vweevers vweevers deleted the test-illegal-types branch June 3, 2018 05:47
@vweevers vweevers added the upgrade guide Improvements or additions to upgrade guide(s) label Jun 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upgrade guide Improvements or additions to upgrade guide(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove DataCloneError try/catch or do the same in batch() Test illegal keys and stringified keys
2 participants