Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Move levelup integration tests to level-browserify #96

Closed
vweevers opened this issue May 25, 2018 · 2 comments
Closed

Move levelup integration tests to level-browserify #96

vweevers opened this issue May 25, 2018 · 2 comments
Assignees
@ralphtheninja

Comments

@vweevers
Copy link
Member

See https://github.com/Level/level.js/blob/master/test/test-levelup.js. It also tests encoding-down.

@ralphtheninja WDYT? On the one hand: can't hurt, and we don't have browser tests in encoding-down yet. On the other hand, it doesn't belong here, and we do already have browser tests in levelup. I have no strong opinion.
@vweevers vweevers added the discussion Discussion label May 25, 2018
@vweevers vweevers added this to the v3 milestone May 25, 2018
@ralphtheninja
Copy link
Member

We could move them to level-browserify instead?

@vweevers
Copy link
Member Author

Good idea.

@vweevers vweevers changed the title Keep or remove levelup integration tests? Move levelup integration tests to level-browserify May 26, 2018
@vweevers vweevers removed this from the v3 milestone May 26, 2018
@vweevers vweevers removed the discussion Discussion label May 26, 2018
@vweevers vweevers mentioned this issue May 27, 2018
Closed
@ralphtheninja ralphtheninja self-assigned this May 27, 2018
@ralphtheninja ralphtheninja mentioned this issue May 27, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ralphtheninja ralphtheninja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralphtheninja @vweevers