Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily skip hallmark test because it breaks citgm #145

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

vweevers
Copy link
Member

Fixes one half of nodejs/citgm#694.

The problem is that CITGM doesn't clone the repo, so hallmark (more specifically, remark-git-contributors) throws. Later on this should fixed in hallmark.

FYI @ralphtheninja

@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Mar 29, 2019
@vweevers vweevers merged commit 8fd6934 into master Mar 29, 2019
@vweevers vweevers deleted the skip-hallmark-test branch March 29, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Bug fixes that are backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant