Segfault when calling iterator without open

[finnp]

Hey,

when calling the iterator without open first I get a

[1]    37329 segmentation fault  node reproduce.js

when doing this with a missing open:

var db = require('leveldown')('test')
var iterator = db.iterator()

Best,
Finn

[finnp]

I also get it when opening another leveldown on the same location:

var level = require('leveldown')

var db1 = level('test')
var db2 = level('test')

db1.open(function () {
  db2.open(function () {
    db2.iterator()
  })
})

[kesla]

Yeah, maybe we should show something nice than a segfault, however you need to open the db before using it - so these cases will still create an error for you.

With regards to the second case - when you try to open it a second time you should be getting an error, so the database isn't open then. See https://github.com/google/leveldb#limitations for more info

https://github.com/Level/deferred-leveldown or https://github.com/rvagg/node-levelup can help you out

[finnp]

Ah yeah so the second example can be reduced to the first one.

To be clear I am aware that both of these snippets are wrong. I just don't think a segfault is an acceptable error here.

[rvagg]

Agreed @finnp, it's always been our priority to fix any segfaultage and this comes under that category. Thanks for reporting, if you have time to investigate a fix then we'd love to see it! It should be fairly straight forward state checking and returning (or throwing) an error.

[ralphtheninja]

Still problems on 1.7.1