Update next to latest abstract-leveldown #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
changed the title
24 tasks
Looks good! |
ralphtheninja
approved these changes
Sep 22, 2018
|
@ralphtheninja does the reasoning in commit message f267647 seem OK to you? |
It makes sense. |
This was referenced Sep 22, 2018
With undefined behavior for nullish targets (range options and seek targets). Previously, nullish range options were ignored and seek(null) and seek(undefined) would throw an error. Now they translate to String(null) and String(undefined). This change makes it explicit that leveldown only supports buffers and strings. Nullish targets do have a meaning in the ecosystem; that meaning should be given at a higher level like encoding-down. In other words, it isn't leveldown's concern anymore.
vweevers
force-pushed
the
next-serialization2
branch
from
37e4eee
to
1e363aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also rebased the
nextbranch on top of master. Made a mistake (my localnextbranch was out-of-sync) but fixed it. @ralphtheninja if you still have a localnextbranch, can you check that it has the same commits asorigin/next?