Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm script to pull binaries from CI, before npm publish #557

Closed
vweevers opened this issue Dec 16, 2018 · 3 comments
Closed

Add npm script to pull binaries from CI, before npm publish #557

vweevers opened this issue Dec 16, 2018 · 3 comments
Assignees
Labels
maintenance General maintenance
Milestone

Comments

@vweevers
Copy link
Member

Using prebuildify-ci download. Also, should we document this required step? @ralphtheninja

@vweevers vweevers added the maintenance General maintenance label Dec 16, 2018
@vweevers vweevers added this to the 5.0.0-rc1 milestone Dec 16, 2018
@ralphtheninja
Copy link
Member

Using prebuildify-ci download. Also, should we document this required step? @ralphtheninja

Yeah, lets do it for transparency and if anyone is wondering about it.

@ralphtheninja
Copy link
Member

Ps. It's also nice to have around, even if you do know it, as a check list.

@vweevers
Copy link
Member Author

Ps. It's also nice to have around, even if you do know it, as a check list.

Agree, esp. because the "build flows" are now different for leveldown, rocksdb, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance
Projects
None yet
Development

No branches or pull requests

2 participants