You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After reading a bit, I see why you'd want to keep virtual. It makes no difference to the compiler, but it's helpful information to humans. Without it you'd have to look at the base class to find a method is virtual.
So instead I want to:
Make structs final (rather than their methods); I now realize that's what I wanted to communicate
Replace virtual with the override keyword where appropriate (this still communicates the virtualness, and checks that the base class' method is virtual).
E.g. instead of:
leveldown/binding.cc
Lines 848 to 850 in 3ff48f1
Write:
The text was updated successfully, but these errors were encountered: