Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error in iterator_seek if iterator has ended #618

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Throw error in iterator_seek if iterator has ended #618

merged 1 commit into from
Apr 26, 2019

Conversation

vweevers
Copy link
Member

Cherry picked from #601.

We do the same check in JS-land (in abstract-leveldown), so this is purely for safety.

@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Apr 26, 2019
@vweevers vweevers requested a review from peakji April 26, 2019 08:17
@vweevers vweevers merged commit 7312cbb into master Apr 26, 2019
@vweevers vweevers deleted the iterator-seek-throw-if-ended branch April 26, 2019 12:50
@vweevers vweevers mentioned this pull request Oct 2, 2019
Closed
@braydonf braydonf mentioned this pull request Oct 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peakji peakji peakji approved these changes

Assignees
No one assigned
Labels
semver-patch Bug fixes that are backward compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vweevers @peakji