Skip writing empty (chained) batch and make callbacks asynchronous #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
added
bug
This comment has been minimized.
This comment has been minimized.
This was referenced Apr 26, 2019
vweevers
force-pushed
the
fix-empty-batch
branch
from
4befcf7
to
10f863e
Compare
|
Canary-tested against Level/abstract-leveldown#337, all good. |
peakji
approved these changes
Apr 26, 2019
|
Something for a rainy day: I think we can refactor chained and array-form batch to both use the => #623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While hunting for bugs (see thread in #601) I found that:
hasData_property of chained batch is unused. Though LevelDB seems to be fine with writing an empty batch, this PR skips that ifhasData_is false, so that the behavior is symmetric withbatch([])(array-form) and withleveldown@4x.batch([])(array-form) isn't asynchronous if the array is empty.