Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new linux prebuild #675

Closed
vweevers opened this issue Oct 4, 2019 · 11 comments
Closed

Test new linux prebuild #675

vweevers opened this issue Oct 4, 2019 · 11 comments
Labels
help wanted Extra attention is needed test Improvements or additions to tests

Comments

@vweevers
Copy link
Member

vweevers commented Oct 4, 2019

Since #674, our prebuilt binary for linux is made on CentOS 7 rather than Ubuntu 16.04, making the binary compatible with Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7. Before releasing 5.3.0 we'd like to test the binary on various linux flavors, including those we already supported.

To do so, run npm i leveldown@next (5.3.0-0). If it unexpectedly falls back to compiling, raise your hand. If you have time to spare, also run a more thorough test:

git clone --recurse-submodules https://github.com/Level/leveldown.git
cd leveldown
rm build/ -rf
npm install
npm run download-prebuilds
npm run test-prebuild

Comment below with results. Thanks!

@ralphtheninja @rvagg @peakji

@vweevers vweevers added help wanted Extra attention is needed test Improvements or additions to tests labels Oct 4, 2019
@vweevers
Copy link
Member Author

vweevers commented Oct 4, 2019

Install works and tests pass in these docker images:

  • node:lts-jessie
  • node:lts-stretch
  • node:lts-buster
  • node:lts-alpine
  • centos/nodejs-10-centos7

@vweevers
Copy link
Member Author

vweevers commented Oct 4, 2019

Also OK on:

  • Ubuntu Server 17.04 with node 12.11.1
  • Amazon Linux 2 with node 8.16.0

@vweevers
Copy link
Member Author

vweevers commented Oct 4, 2019

On FreeBSD 12.0 with node 12.8.1, the prebuild fails to load with:

Error: Shared object "libstdc++.so.6" not found, required by "node.napi.node"

But node-gyp-build correctly falls back to compiling. Tests pass too.

@ralphtheninja

This comment has been minimized.

@vweevers

This comment has been minimized.

@ralphtheninja

This comment has been minimized.

@ralphtheninja
Copy link
Member

Ok on Ubuntu 19.04 with node 12.11.1

@rvagg
Copy link
Member

rvagg commented Oct 4, 2019

Weirdly it even worked on an Ubuntu 12.04 system I happen to have running, with Node 10. That's an older libc but maybe it's not getting newer symbols involved. So that's pretty impressive.

@peakji
Copy link
Member

peakji commented Oct 4, 2019

Ok on RedHat RHEL 7.2, with node LTS

@vweevers
Copy link
Member Author

vweevers commented Oct 4, 2019

So, good to release?

@vweevers vweevers closed this as completed Oct 4, 2019
@vweevers
Copy link
Member Author

vweevers commented Oct 4, 2019

Released 5.3.0 (took a while due to queued CI jobs). Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed test Improvements or additions to tests
Projects
None yet
Development

No branches or pull requests

4 participants