Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cirrus CI for FreeBSD tests #678

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Add Cirrus CI for FreeBSD tests #678

merged 1 commit into from
Oct 5, 2019

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Oct 5, 2019

No description provided.

@vweevers vweevers added the test Improvements or additions to tests label Oct 5, 2019
@vweevers

This comment has been minimized.

- Add .cirrus.yml
- Update libnghttp2 to fix "undefined symbol
  nghttp2_option_set_max_outbound_ack" when running node
- Skip downloading Electron because it doesn't support FreeBSD.
  To achieve that we need Electron v7 beta which introduces a
  ELECTRON_SKIP_BINARY_DOWNLOAD environment variable.
  See: electron/electron#17627
- Use "npm i --unsafe-perm" because scripts run as root
@vweevers vweevers marked this pull request as ready for review October 5, 2019 08:50
@vweevers vweevers changed the title Try out Cirrus CI (FreeBSD) Add Cirrus CI for FreeBSD tests ✨ Oct 5, 2019
@vweevers vweevers changed the title Add Cirrus CI for FreeBSD tests ✨ Add Cirrus CI for FreeBSD tests Oct 5, 2019
Copy link
Member

@ralphtheninja ralphtheninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✨

@vweevers vweevers merged commit 975ea2a into master Oct 5, 2019
@vweevers vweevers deleted the cirrus-ci branch October 5, 2019 09:06
vweevers added a commit that referenced this pull request Oct 8, 2019
The beta was previously needed for ELECTRON_SKIP_BINARY_DOWNLOAD,
see 975ea2a. Electron folks kindly backported that feature to v6.

Ref #678
Ref electron/electron#20438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants