Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Fix android arm64 prebuild by disabling exceptions #706

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

vweevers
Copy link
Member

Problem: loading the android-arm64 prebuild failed with "cannot locate symbol _Unwind_Resume". Likely because that symbol does not exist (or is hidden) on some android devices. I could not positively confirm that because I could not get gdb or lldb to work in termux. Luckily we don't have to, because _Unwind_Resume is a function used for exceptions, which we don't need AFAICT.

Solution: disable exceptions, on both our code and leveldb code.

Closes #705.

@christianbundy, /cc @staltz as the author of #411 which enabled exceptions.

@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Feb 22, 2020
@vweevers
Copy link
Member Author

I ran npm t as well as npm run test-gc in termux, with a prebuild and built from source, all pass.

@vweevers vweevers merged commit 279bbcb into master Feb 24, 2020
@vweevers vweevers deleted the android-no-exceptions branch February 24, 2020 21:56
@vweevers
Copy link
Member Author

5.5.1 (published shortly after 5.5.0, for which I had already pushed git tags but I couldn't publish yet).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semver-patch Bug fixes that are backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dlopen failed: cannot locate symbol "_Unwind_Resume"
2 participants