-
-
Notifications
You must be signed in to change notification settings - Fork 177
pull in parts of mafintosh/leveldown-prebuilt#master #188
Conversation
Seems to be some problems on travis for iojs versions. Not sure what's going on here. /cc @mafintosh |
Yes we should probably just remove the "bump version" commits + change the host to this repo |
@mafintosh Hmm yes. I'm wondering what's the best way to do that. Perhaps I should just take your master branch and |
So this is kind of tricky to rewrite since the master branch of leveldown has been merged twice into your branch. I think I prefer just doing a merge from |
@mafintosh I did as follows. I created a new branch based on commit 541a065: Then merged latest Essentially undoing: and |
}, | ||
"license": "MIT", | ||
"gypfile": true | ||
"gypfile": true, | ||
"bundledDependencies": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because https://github.com/mapbox/node-pre-gyp#1-add-new-entries-to-your-packagejson, not sure why it's not just a dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok, weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node-pre-gyp needs to be a bundledDep (sadly) because otherwise it might not be usable (fully installed) by the time npm calls out to it. See mapbox/node-pre-gyp#162 for ideas about avoiding this (and being able to safely have node-pre-gyp dynamically installed and still available in time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fwiw, this seems to work fine https://github.com/Level/leveldown/blob/node-pre-gyp-and-travis/package.json#L30-L36 with travis
+1 |
|
Tests failed because I deleted my remote branch. Just fyi. |
No description provided.