Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options argument to Batch#write #603

Closed
vweevers opened this issue Jul 13, 2018 · 0 comments
Closed

Add options argument to Batch#write #603

vweevers opened this issue Jul 13, 2018 · 0 comments
Assignees
@ralphtheninja

Comments

@vweevers
Copy link
Member

levelup/lib/batch.js

Line 50 in c3845ee

Batch.prototype.write = function (callback) {

The argument can default to {} (so this is safe to release as a patch) and then passed to:

levelup/lib/batch.js

Line 61 in c3845ee

this.batch.write(function (err) {

Passing options to write has been supported in abstract-leveldown since forever: Level/abstract-leveldown@efbd19a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ralphtheninja ralphtheninja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralphtheninja @vweevers