Create test suite #677
Merged
Create test suite #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
added
semver-patch
vweevers
commented
Sep 22, 2019
|
|
||
| stderrMock.expects('error').never() |
There was a problem hiding this comment.
Besides this not actually working anymore (because node emits a warning event rather than error), it caused problems when calling the test multiple times: sinon complained console was already wrapped.
vweevers
commented
Sep 22, 2019
| // TODO to make this pass: | ||
| // - Have abstract-leveldown use level-errors | ||
| // - Perform type checks in same order (e.g. check key before callback) | ||
| // - Add db.isClosed(), isOpen() to abstract-leveldown |
vweevers
commented
Sep 22, 2019
| options = xtend(options, { | ||
| keyAsBuffer: false, | ||
| valueAsBuffer: false | ||
| }) |
There was a problem hiding this comment.
The tests implicitly relied on the default utf8 encoding, for the db to return strings. When the db isn't wrapped with encoding-down, *asBuffer: false achieves the same.
|
Travis error: That's new.. |
ralphtheninja
approved these changes
Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #273. Doesn't fully achieve what that ticket describes (being able to call the test suite externally would require moving devDependencies to dependencies, or moving the whole thing to its own module), but there's no use case for that anymore. So, this PR is more about being able to reuse the test suite internally. This allows us to test feature parity between
levelupandabstract-leveldown(Level/community#58).