Add manifest #678
Merged
Add manifest #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
added
enhancement
vweevers
commented
Sep 22, 2019
lib/levelup.js
Outdated
| Object.keys(this.supports.additionalMethods).forEach(function (method) { | ||
| this[method] = this[method] || function () { | ||
| // TODO: uhm. if the manifest is based on deferred-leveldown's, | ||
| // should we also call the methods via deferred-leveldown? |
There was a problem hiding this comment.
Can work if we agree that deferred-leveldown itself must not add methods to its additionalMethods; it should inherit that from its input db (same as levelup).
40 tasks
vweevers
commented
Sep 22, 2019
31 tasks
ralphtheninja
approved these changes
Sep 22, 2019
vweevers
commented
Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.