Increase abstract-leveldown parity #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add db property to chained batch - Remove type checks that are also performed by abstract-leveldown Goes hand in hand with Level/abstract-leveldown#364.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbproperty to chained batchabstract-leveldownGoes hand in hand with Level/abstract-leveldown#364. Working towards Level/community#58.
I think I can get away with a semver-minor release here, because although
levelupnow yields some errors asynchronously instead of throwing, those errors are "courtesy errors" for documented limitations or programmer errors. You shouldn't be catching them.(I would prefer that we throw btw, but atm that makes achieving parity harder)