Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor promisify() code by using catering module #700

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Conversation

ralphtheninja
Copy link
Member

Closes #699

@ralphtheninja ralphtheninja added the semver-patch Bug fixes that are backward compatible label Sep 26, 2020
@vweevers
Copy link
Member

Could be considered a breaking change because we did if (!callback) here, while catering does if (callback === undefined). The latter matches documented behavior though so I think it's OK. The docs never suggested we support e.g. await db.get('foo', null) the same as await db.get('foo').

@ralphtheninja ralphtheninja merged commit 33b1318 into master Sep 27, 2020
@ralphtheninja ralphtheninja deleted the catering branch September 27, 2020 08:14
@ralphtheninja
Copy link
Member Author

Could be considered a breaking change because we did if (!callback) here, while catering does if (callback === undefined). The latter matches documented behavior though so I think it's OK. The docs never suggested we support e.g. await db.get('foo', null) the same as await db.get('foo').

Good catch. I didn't think that far. My OCD just told me to replace the code with your tested module :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Bug fixes that are backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor to use fromCallback from catering module
2 participants