Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hidden directory from data #235

Open
ndporter opened this issue Aug 8, 2023 · 7 comments
Open

Remove hidden directory from data #235

ndporter opened this issue Aug 8, 2023 · 7 comments

Comments

@ndporter
Copy link

ndporter commented Aug 8, 2023

The shell-lesson-data.zip file includes a hidden __MACOSX directory that is visible when running ls in Git Bash (and thus potentially confusing to learners. Ideally, the datafile should be updated to remove this extra cognitive load (and filesize) unless there is a reason it needs to be there.

@jmjamison
Copy link
Contributor

I think that the removing the __MACOSX folder would impact the MacOS users and require separate lesson files. That's my guess, I'm a Windows/Linux user so anything specific to MacOS is a guess for me.

That said I don't think a brief explanation would throw the class off course. It might be helpful for new users to know what to ignore based on their OS.

contents
directory

@emcaulay
Copy link
Contributor

I think the __MACOSX file is not necessary. But I can test if you want me to.

@jmjamison
Copy link
Contributor

@emcaulay If you could test this out that would be very helpful. Not using MacOS I have no idea if that file is necessary. Thank you.

@emcaulay
Copy link
Contributor

I tested it, and that part of the file is not necessary. I made a new zip and shared with @jmjamison -- and I think it's free of Mac detritus. Jamie will review next week.

@emcaulay
Copy link
Contributor

(I shared a new zip with her via Slack since I can't upload the zip to the repo)

@jmjamison
Copy link
Contributor

And I learned something new about MacOS files.

@kaitlinnewson
Copy link
Member

@jmjamison has this new file been update in this repo? I didn't notice any pull request for it.

@kaitlinnewson kaitlinnewson reopened this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants