FEAT: add crontab to the docker image, setup default cron jobs.

[bpinsard]

Allo!

I think the docker image could package cron and crontab to allow scheduling the jobs here.
https://github.com/LibreBooking/app/tree/develop/Jobs
Setting up the crontab by default for these tasks could be done in the Dockerfile.

Cheers

[colisee]

Hi @bpinsard ,

Thank you very much for your proposal.

How about letting the host (ie. the server running the docker container) take care of the periodic tasks like the librebooking jobs through its own cron or systemd timer mechanism?

This way:

1. the host would periodically run a command like docker exec --detach <container_name> php -f /var/www/html/Jobs/sendreminders.php
2. we would keep the docker image as small as possible

What do you think?

[bpinsard]

Thanks for the rapid feedback.
I think the goal of containers is to package a software and all it's features into one thing. This avoids having to do separate setup to access these features and thus ease deployment. I will check how much the cron package makes the image bigger and get back to you with numbers.

[colisee]

Bonjour @bpinsard ,
Developers have different views on what a container should include: some (like me) prefer to have a container focusing on one task and other to have a container doing everything.

Having said that, I understand that it could be easier to control recurrent jobs within the container instead of controlling them from the host. I will review your changes and maybe propose some changes in order to offer more flexibility (not everyone want to run recurrent jobs and some might run other available jobs you didn’t include).

A bientôt.

[colisee]

Bonjour @bpinsard

I reviewed your changes.
The crontab file should not be recorded inside the librebooking image, but mapped at run time through the --volume argument (I will need to change the documentation once your changes are merged)