Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with groupfolders app when limiting LibreSign to groups #3351

Open
w1n5l0w opened this issue Jul 11, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@w1n5l0w
Copy link

w1n5l0w commented Jul 11, 2024

Describe the bug
When I limit the usage of LibreSign to a specific group (can be any group, doesn't have to be the admin-group) in the app settings, then all users who don't belong to this group can't access groupfolders it the WebUI of the file app anymore (access via synced Nextcloud Desktop app works). These user see the groupfolders in the File app, but they are only a link to the webdav endpoint and one can't access the groupfolders via WebUI.

To Reproduce
Steps to reproduce the behavior:

  • I'm an admin user, the groufolders app is installed and there is at least one groupfolder created to which i have access to
  • Go to 'App Settings' (/settings/apps/)
  • Click on 'LibreSign' and limit the usage of the app to an group I am not a member of
  • Go to 'Files app' (/apps/files/)
  • I can't access the groupfolder anymore, the listed groupfolder only provides a link to /remote.php/dav/files///

Expected behavior
Any user can access the groupfolders to which s/he has access, no matter if the usage of the LibreSign app is limited to group(s)

Environment information (please complete the following information):

  • OS: Debian Bookworm
  • Browser: Doesn't matter if Firefox or Chromium
  • LibreSign Version 9.2.0
  • Nextcloud Server Version 29.0.3
  • Logs (get the entries from nextcloud.log related with LibreSign i.e tail -f data/nextcloud.log|grep libresign)
{"reqId":"QoHC0DOxs3qTqDhpJNI2","level":3,"time":"2024-07-11T21:50:03+00:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":"Error while running background job OCA\\Libresign\\BackgroundJob\\UserDeleted (id: 321, arguments: null)","userAgent":"--","version":"29.0.3.4","exception":{"Exception":"TypeError","Message":"OCA\\Libresign\\Db\\FileMapper::neutralizeDeletedUser(): Argument #1 ($userId) must be of type string, null given, called in /srv/nextcloud/app/apps/libresign/lib/BackgroundJob/UserDeleted.php on line 39","Code":0,"Trace":[{"file":"/srv/nextcloud/app/apps/libresign/lib/BackgroundJob/UserDeleted.php","line":39,"function":"neutralizeDeletedUser","class":"OCA\\Libresign\\Db\\FileMapper","type":"->"},{"file":"/srv/nextcloud/app/lib/public/BackgroundJob/Job.php","line":80,"function":"run","class":"OCA\\Libresign\\BackgroundJob\\UserDeleted","type":"->"},{"file":"/srv/nextcloud/app/lib/public/BackgroundJob/QueuedJob.php","line":57,"function":"start","class":"OCP\\BackgroundJob\\Job","type":"->"},{"file":"/srv/nextcloud/app/lib/public/BackgroundJob/QueuedJob.php","line":47,"function":"start","class":"OCP\\BackgroundJob\\QueuedJob","type":"->"},{"file":"/srv/nextcloud/app/cron.php","line":177,"function":"execute","class":"OCP\\BackgroundJob\\QueuedJob","type":"->"}],"File":"/srv/nextcloud/app/apps/libresign/lib/Db/FileMapper.php","Line":227,"message":"Error while running background job OCA\\Libresign\\BackgroundJob\\UserDeleted (id: 321, arguments: null)","exception":{},"CustomMessage":"Error while running background job OCA\\Libresign\\BackgroundJob\\UserDeleted (id: 321, arguments: null)"}}
{"reqId":"aVnCH7YD4YIgqJMuDUC1","level":3,"time":"2024-07-11T22:15:02+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"Trying to access array offset on value of type null at /srv/nextcloud/app/apps/libresign/lib/BackgroundJob/UserDeleted.php#34","userAgent":"--","version":"29.0.3.4","data":{"app":"PHP"}}
{"reqId":"aVnCH7YD4YIgqJMuDUC1","level":3,"time":"2024-07-11T22:15:02+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"Trying to access array offset on value of type null at /srv/nextcloud/app/apps/libresign/lib/BackgroundJob/UserDeleted.php#35","userAgent":"--","version":"29.0.3.4","data":{"app":"PHP"}}
{"reqId":"aVnCH7YD4YIgqJMuDUC1","level":3,"time":"2024-07-11T22:15:02+00:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":"Error while running background job OCA\\Libresign\\BackgroundJob\\UserDeleted (id: 325, arguments: null)","userAgent":"--","version":"29.0.3.4","exception":{"Exception":"TypeError","Message":"OCA\\Libresign\\Db\\FileMapper::neutralizeDeletedUser(): Argument #1 ($userId) must be of type string, null given, called in /srv/nextcloud/app/apps/libresign/lib/BackgroundJob/UserDeleted.php on line 39","Code":0,"Trace":[{"file":"/srv/nextcloud/app/apps/libresign/lib/BackgroundJob/UserDeleted.php","line":39,"function":"neutralizeDeletedUser","class":"OCA\\Libresign\\Db\\FileMapper","type":"->"},{"file":"/srv/nextcloud/app/lib/public/BackgroundJob/Job.php","line":80,"function":"run","class":"OCA\\Libresign\\BackgroundJob\\UserDeleted","type":"->"},{"file":"/srv/nextcloud/app/lib/public/BackgroundJob/QueuedJob.php","line":57,"function":"start","class":"OCP\\BackgroundJob\\Job","type":"->"},{"file":"/srv/nextcloud/app/lib/public/BackgroundJob/QueuedJob.php","line":47,"function":"start","class":"OCP\\BackgroundJob\\QueuedJob","type":"->"},{"file":"/srv/nextcloud/app/cron.php","line":177,"function":"execute","class":"OCP\\BackgroundJob\\QueuedJob","type":"->"}],"File":"/srv/nextcloud/app/apps/libresign/lib/Db/FileMapper.php","Line":227,"message":"Error while running background job OCA\\Libresign\\BackgroundJob\\UserDeleted (id: 325, arguments: null)","exception":{},"CustomMessage":"Error while running background job OCA\\Libresign\\BackgroundJob\\UserDeleted (id: 325, arguments: null)"}}
@w1n5l0w w1n5l0w added the bug Something isn't working label Jul 11, 2024
@vitormattos
Copy link
Member

Sounds that this log isn't related to described scenario.

@vitormattos
Copy link
Member

I think that I didn't understood your scenario. Could you explain with more details?

@w1n5l0w
Copy link
Author

w1n5l0w commented Jul 12, 2024

I can try. But what exactly don't you understand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 0. Needs triage
Development

No branches or pull requests

2 participants