Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dependencies and remove JSDOM usage #111

Conversation

pragmaticivan
Copy link
Contributor

@pragmaticivan pragmaticivan commented Nov 16, 2017

fixes #112

@pragmaticivan pragmaticivan changed the title Updates to alpha version [WIP] Updates npm package and removes JSDOM Nov 16, 2017
@pragmaticivan
Copy link
Contributor Author

Ebert has finished reviewing this Pull Request and has found:

  • 29 possible new issues (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/wedeploy/magnet/pulls/111.

@codecov-io
Copy link

codecov-io commented Nov 16, 2017

Codecov Report

Merging #111 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage    91.4%   91.26%   -0.14%     
==========================================
  Files          11       11              
  Lines         256      252       -4     
==========================================
- Hits          234      230       -4     
  Misses         22       22
Impacted Files Coverage Δ
src/build/server.js 91.66% <ø> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d63531...0168d39. Read the comment docs.

@pragmaticivan pragmaticivan changed the title [WIP] Updates npm package and removes JSDOM Updates dependencies and remove JSDOM usage Dec 4, 2017
@pragmaticivan
Copy link
Contributor Author

Closing for now, it's outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies and remove JSDOM usage
2 participants