-
Notifications
You must be signed in to change notification settings - Fork 212
raise clear error for module not available #1425
raise clear error for module not available #1425
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
- Coverage 92.89% 85.12% -7.78%
==========================================
Files 286 286
Lines 12870 12874 +4
==========================================
- Hits 11956 10959 -997
- Misses 914 1915 +1001
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @aniketmaurya for this PR! LGTM 🔥 A suggestion and a question:
- Let's also add
torchvision
requirement todatatype_audio.txt
file, since we need it for audio classification. Can you please do this in this PR? - Question: just cross-checking, did you make sure that a clearer error is raised if kornia is not installed and a user attempts to run this example?
Also, I've modified the PR description for future reference, just in case anyone hops on this for any reason! :) Hope that sounds good to you.
Thank you for reviewing the PR and suggestions @krshrimali 😄 !
|
@aniketmaurya - Sounds great, thank you so much! However, I can't see any commit after your comment. Did you forget to push the changes for requirements? ;) |
Hi @krshrimali, yeah sorry I forgot to push it earlier. I've updated the PR just now! 😅 |
Update: added CHANGELOG entries! cc: @ethanwharris - if you can merge this whenever you are back! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just small suggestions to require lightning-flash[image]
or lightning-flash[audio]
rather than the libraries themselves
What does this PR do?
Fixes #1422 #1423. This PR:
@requires("kornia")
decorator to image segmentation input transform code for better coverage and clearer error.torchvision
, arequires
decorator for torchvision is also added in the relevant file.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃