Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

fix: datamodule can't load files with square brackets in names #1501

Merged
merged 15 commits into from
Jan 20, 2023
Merged

fix: datamodule can't load files with square brackets in names #1501

merged 15 commits into from
Jan 20, 2023

Conversation

yurijmikhalevich
Copy link
Contributor

@yurijmikhalevich yurijmikhalevich commented Dec 26, 2022

What does this PR do?

This PR makes flash.DataModule support files with square brackets (and other glob patterns) in the filenames. More details are in #1500.

Closes #1500.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

requirements.txt Outdated Show resolved Hide resolved
@Borda Borda added the bug / fix Something isn't working label Jan 5, 2023
@yurijmikhalevich yurijmikhalevich marked this pull request as draft January 9, 2023 12:30
@yurijmikhalevich
Copy link
Contributor Author

Converted to draft because this is missing a test for an URL containing [whatever]

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending on #1501 (comment)

@yurijmikhalevich yurijmikhalevich marked this pull request as ready for review January 15, 2023 20:50
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borda Borda merged commit e685a92 into Lightning-Universe:master Jan 20, 2023
@yurijmikhalevich yurijmikhalevich deleted the fix/datamodule-cant-load-files-with-square-brackets-in-names branch January 20, 2023 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flash.DataModule can't load files with a pair of square brackets in the filename
5 participants