This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
fix: datamodule can't load files with square brackets in names #1501
Merged
Borda
merged 15 commits into
Lightning-Universe:master
from
yurijmikhalevich:fix/datamodule-cant-load-files-with-square-brackets-in-names
Jan 20, 2023
Merged
fix: datamodule can't load files with square brackets in names #1501
Borda
merged 15 commits into
Lightning-Universe:master
from
yurijmikhalevich:fix/datamodule-cant-load-files-with-square-brackets-in-names
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurijmikhalevich
requested review from
ethanwharris,
Borda,
tchaton,
justusschock and
krshrimali
as code owners
December 26, 2022 18:46
Borda
approved these changes
Dec 27, 2022
akihironitta
approved these changes
Jan 3, 2023
Converted to draft because this is missing a test for an URL containing |
Borda
suggested changes
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending on #1501 (comment)
Borda
approved these changes
Jan 18, 2023
for more information, see https://pre-commit.ci
ethanwharris
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
yurijmikhalevich
deleted the
fix/datamodule-cant-load-files-with-square-brackets-in-names
branch
January 20, 2023 12:09
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes
flash.DataModule
support files with square brackets (and other glob patterns) in the filenames. More details are in #1500.Closes #1500.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃