You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is not a lot of code in training_trick_connector.py and rather than maintain a separate class to slightly extend the logic in the trainer, we can simplify things by moving the logic to trainer and removing training_trick_connector.
The text was updated successfully, but these errors were encountered:
Proposed refactoring or deprecation
Move the code from
on_trainer_init
in training_trick_connector to trainer.py and remove training_trick_connectorhttps://github.com/PyTorchLightning/pytorch-lightning/blob/c9bc10ce8473a2249ffa4e00972c0c3c1d2641c4/pytorch_lightning/trainer/connectors/training_trick_connector.py#L24
Motivation
There is not a lot of code in
training_trick_connector.py
and rather than maintain a separate class to slightly extend the logic in the trainer, we can simplify things by moving the logic to trainer and removingtraining_trick_connector
.The text was updated successfully, but these errors were encountered: