Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move training_trick_connector code to trainer.py #10108

Closed
daniellepintz opened this issue Oct 24, 2021 · 0 comments · Fixed by #10112
Closed

Move training_trick_connector code to trainer.py #10108

daniellepintz opened this issue Oct 24, 2021 · 0 comments · Fixed by #10112
Assignees
Labels

Comments

@daniellepintz
Copy link
Contributor

daniellepintz commented Oct 24, 2021

Proposed refactoring or deprecation

Move the code from on_trainer_init in training_trick_connector to trainer.py and remove training_trick_connector
https://github.com/PyTorchLightning/pytorch-lightning/blob/c9bc10ce8473a2249ffa4e00972c0c3c1d2641c4/pytorch_lightning/trainer/connectors/training_trick_connector.py#L24

Motivation

There is not a lot of code in training_trick_connector.py and rather than maintain a separate class to slightly extend the logic in the trainer, we can simplify things by moving the logic to trainer and removing training_trick_connector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant