-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move env_vars_connector.py
to utilities file
#10161
Comments
@Borda do you know if it is being used outside of Lightning (we don't have usages inside of Lightning afaik). |
I a not aware of this one... |
Should we go ahead and remove it as part of 1.5 then? cc @tchaton |
Dear @daniellepintz, I know some users are relying on this to inject dynamically parameters within the Trainer as env variable. Personally, I am in favor of keeping it. |
env_vars_connector.py
being used?env_vars_connector.py
to utilities file
Proposed refactoring or deprecation
Is this being used or can we remove this?
https://github.com/PyTorchLightning/pytorch-lightning/blob/c33df2639f19d49c5e7520294e3221efe402d684/pytorch_lightning/trainer/connectors/env_vars_connector.py#L21
The text was updated successfully, but these errors were encountered: