Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move env_vars_connector.py to utilities file #10161

Closed
daniellepintz opened this issue Oct 26, 2021 · 4 comments · Fixed by #10501
Closed

Move env_vars_connector.py to utilities file #10161

daniellepintz opened this issue Oct 26, 2021 · 4 comments · Fixed by #10501
Assignees
Labels

Comments

@daniellepintz
Copy link
Contributor

Proposed refactoring or deprecation

Is this being used or can we remove this?
https://github.com/PyTorchLightning/pytorch-lightning/blob/c33df2639f19d49c5e7520294e3221efe402d684/pytorch_lightning/trainer/connectors/env_vars_connector.py#L21

@awaelchli
Copy link
Contributor

@Borda do you know if it is being used outside of Lightning (we don't have usages inside of Lightning afaik).

@Borda
Copy link
Member

Borda commented Oct 27, 2021

@Borda do you know if it is being used outside of Lightning (we don't have usages inside of Lightning afaik).

I a not aware of this one...

@daniellepintz
Copy link
Contributor Author

Should we go ahead and remove it as part of 1.5 then? cc @tchaton

@tchaton
Copy link
Contributor

tchaton commented Oct 28, 2021

Dear @daniellepintz,

I know some users are relying on this to inject dynamically parameters within the Trainer as env variable. Personally, I am in favor of keeping it.

@daniellepintz daniellepintz changed the title Is env_vars_connector.py being used? Move env_vars_connector.py to utilities file Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants