Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_amp is broken in 0.7.0 #1143

Closed
rmrao opened this issue Mar 13, 2020 · 2 comments · Fixed by #1145
Closed

use_amp is broken in 0.7.0 #1143

rmrao opened this issue Mar 13, 2020 · 2 comments · Fixed by #1145
Assignees
Labels
bug Something isn't working good first issue Good for newcomers priority: 0 High priority task
Milestone

Comments

@rmrao
Copy link
Contributor

rmrao commented Mar 13, 2020

I see that use_amp is deprecated but since the Trainer still accepts it as an argument, I believe this is still a bug.

The issue is that the hook that deals with this specifically checks if trainer.precision == 16. However, the Trainer does not set precision = 16 if use_amp = True.

Proposed solution:

if use_amp is passed in, set precision = 16 and raise a deprecation warning.

@Borda Borda added bug Something isn't working good first issue Good for newcomers help wanted Open to be worked on labels Mar 14, 2020
@Borda
Copy link
Member

Borda commented Mar 14, 2020

that s a good catch, thx! could send a fix PR? 🤖

@Borda Borda added this to the 0.7.2 milestone Mar 14, 2020
@rmrao
Copy link
Contributor Author

rmrao commented Mar 14, 2020

Submitted!

@Borda Borda removed the help wanted Open to be worked on label Mar 14, 2020
@Borda Borda added the priority: 0 High priority task label Apr 3, 2020
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers priority: 0 High priority task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants