Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename finalize to teardown in Logger API #11677

Closed
daniellepintz opened this issue Jan 31, 2022 · 3 comments
Closed

Rename finalize to teardown in Logger API #11677

daniellepintz opened this issue Jan 31, 2022 · 3 comments
Labels
deprecation Includes a deprecation logger Related to the Loggers refactor

Comments

@daniellepintz
Copy link
Contributor

daniellepintz commented Jan 31, 2022 •
edited
Loading

Proposed refactor

Rename finalize to teardown in Logger API:
https://github.com/PyTorchLightning/pytorch-lightning/blob/86b177ebe5427725b35fde1a8808a7b59b8a277a/pytorch_lightning/loggers/base.py#L319-L325

Motivation

teardown is the name we use in other classes in Lightning for the purpose of doing any final processing/cleanup.

Similar to #10939

This was discussed in #9004 (reply in thread)

cc @justusschock @awaelchli @akihironitta @rohitgr7 @edward-io @Borda @ananthsub @kamil-kaczmarek @Raalsky @Blaizzy @tchaton
@daniellepintz daniellepintz added refactor logger Related to the Loggers labels Jan 31, 2022
@awaelchli awaelchli added this to the 1.6 milestone Feb 5, 2022
@awaelchli awaelchli added the deprecation Includes a deprecation label Feb 5, 2022
@ananthsub
Copy link
Contributor

These have different semantics today. finalize accepts success/failure, while teardown accepts the stage (ie fit validate test predict), but does not give an indication about success/failure. How do you plan to bridge this?

@daniellepintz
Copy link
Contributor Author

Hmm good point. Maybe it doesn't make sense to do this issue?

@carmocca carmocca modified the milestones: 1.6, 1.7 Feb 16, 2022
@carmocca carmocca removed this from the pl:1.7 milestone Jul 19, 2022
@carmocca
Copy link
Contributor

Closing as there's no clear proposal

@carmocca carmocca closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation Includes a deprecation logger Related to the Loggers refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ananthsub @awaelchli @akashkw @carmocca @daniellepintz