Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Logger_connector should own the logger, and should not have a Trainer reference #11816

Open
daniellepintz opened this issue Feb 9, 2022 · 1 comment
Assignees
Labels

Comments

@daniellepintz
Copy link
Contributor

daniellepintz commented Feb 9, 2022

Proposed refactor

  • Create a logger property on the logger_connector
  • Create a read-only property on the Trainer called logger which returns logger_connector.logger
  • Remove Trainer reference from logger_connector

Motivation

Part of #10417

Pitch

  • Create a logger property on the logger_connector
  • Update all the reference of trainer.logger on the logger_connector to self.logger
  • Create a read-only property on the Trainer called logger which returns logger_connector.logger
  • Update all the other places where the trainer is used in logger_connector - some variables will have to be passed in the constructor, and others will have to be passed as arguments to some methods such as should_flush_logs
  • Remove Trainer reference from logger_connector

cc @justusschock @awaelchli @akihironitta @rohitgr7 @edward-io @Borda @ananthsub @kamil-kaczmarek @Raalsky @Blaizzy @kaushikb11 @ninginthecloud

@awaelchli
Copy link
Contributor

That would be really nice to have!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants