Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelCheckpointCallback.on_validation_end does not listen to val_check_interval? #1966

Closed
sshleifer opened this issue May 27, 2020 · 5 comments · Fixed by #3807
Closed

ModelCheckpointCallback.on_validation_end does not listen to val_check_interval? #1966

sshleifer opened this issue May 27, 2020 · 5 comments · Fixed by #3807
Labels
help wanted Open to be worked on

Comments

@sshleifer
Copy link
Contributor

Evidence: I have a unit test where I train for 2 epochs with val_check_interval=0.5 and I only get two model checkpoints. Set breakpoints and indeed it is only hit twice. Would expect 4 times.

@sshleifer sshleifer added the help wanted Open to be worked on label May 27, 2020
@HansBambel
Copy link
Contributor

In the ModelCheckpoint class is a parameter period that tells the callback after how many epochs a model is saved. Since this value is supposed to be an int I think it is only possible to save the model after whole epochs.

@sshleifer
Copy link
Contributor Author

Is there any plan to change that or a way to make a checkpointing callback to run on_validation_end?

@williamFalcon
Copy link
Contributor

williamFalcon commented Jun 5, 2020

yes, checkpoint and that API is being reworked atm #1989. Much simpler and much more expressive. that should be rolled out by saturday

@stale
Copy link

stale bot commented Aug 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Aug 4, 2020
@stale stale bot closed this as completed Aug 13, 2020
@williamFalcon williamFalcon reopened this Aug 14, 2020
@stale stale bot removed the won't fix This will not be worked on label Aug 14, 2020
@stale
Copy link

stale bot commented Oct 22, 2020

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Oct 22, 2020
@edenlightning edenlightning removed the won't fix This will not be worked on label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open to be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants