Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing logger folder Warning due to isdir of fsspec #5052

Closed
gqk opened this issue Dec 10, 2020 · 3 comments
Closed

Missing logger folder Warning due to isdir of fsspec #5052

gqk opened this issue Dec 10, 2020 · 3 comments
Labels
bug Something isn't working help wanted Open to be worked on priority: 1 Medium priority task
Milestone
pl:1.2.x

Comments

@gqk
Copy link

gqk commented Dec 10, 2020

🐛 Bug

I linked a folder to PROJECT_ROOT/lightning_logs, but pytorch-lightning showed the warning Missing logger folder: PROJECT_ROOT/lightning_logs, and then wrote the tensorboard event log file to PROJECT_ROOT/lightning_logs/version_0, instead of creating a new version_xxx.

I think this is because in this case, fsspec's isdir returns False, while python os.path.isdir returns True . Please refer to https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/loggers/tensorboard.py#L241 for details.
@gqk gqk added bug Something isn't working help wanted Open to be worked on labels Dec 10, 2020
@github-actions
Copy link
Contributor

Hi! thanks for your contribution!, great first issue!

@Borda Borda added the priority: 1 Medium priority task label Dec 10, 2020
@Borda Borda added this to the 1.1.x milestone Dec 10, 2020
@edenlightning
Copy link
Contributor

Thanks for the issue! @f4hy any idea?

@Borda Borda modified the milestones: 1.1.x, 1.2 Feb 8, 2021
@edenlightning edenlightning modified the milestones: 1.2, 1.2.x Feb 8, 2021
@ethanwharris
Copy link
Member

@gqk Closing as this should now be fixed by #6730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Open to be worked on priority: 1 Medium priority task
Projects
None yet
Milestone
pl:1.2.x
Development

No branches or pull requests
4 participants
@Borda @ethanwharris @edenlightning @gqk