Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve several Horovod test failures #6935

Closed
2 of 6 tasks
carmocca opened this issue Apr 9, 2021 · 8 comments · Fixed by #6954
Closed
2 of 6 tasks

Resolve several Horovod test failures #6935

carmocca opened this issue Apr 9, 2021 · 8 comments · Fixed by #6954
Labels
3rd party Related to a 3rd-party bug Something isn't working ci Continuous Integration help wanted Open to be worked on priority: 1 Medium priority task won't fix This will not be worked on

Comments

@carmocca
Copy link
Contributor

carmocca commented Apr 9, 2021 •
edited
Loading

🐛 Bug

We are currently skipping several Horovod tests. We should eventually address each one.

cc: @Borda @tgaddair
@carmocca carmocca added bug Something isn't working help wanted Open to be worked on ci Continuous Integration labels Apr 9, 2021
@carmocca carmocca added this to the 1.3 milestone Apr 9, 2021
@awaelchli awaelchli mentioned this issue Apr 11, 2021
Merged
11 tasks
@Borda Borda added the 3rd party Related to a 3rd-party label Apr 12, 2021
@Borda
Copy link
Member

Borda commented Apr 12, 2021

@tgaddair could you pls check these issues? 🐰

@carmocca carmocca reopened this Apr 13, 2021
@edenlightning edenlightning added the priority: 2 Low priority task label Apr 27, 2021
@edenlightning
Copy link
Contributor

@tgaddair friendly ping :)

@edenlightning edenlightning added priority: 1 Medium priority task and removed priority: 2 Low priority task labels Apr 27, 2021
@awaelchli awaelchli mentioned this issue May 4, 2021
Closed
11 tasks
@Borda Borda modified the milestones: v1.3, v1.3.x May 6, 2021
@edenlightning
Copy link
Contributor

@Borda still relevant?

@carmocca
Copy link
Contributor Author

The Python errors might be resolved with #8116

@edenlightning
Copy link
Contributor

@carmocca is this fixed?

@edenlightning edenlightning removed this from the v1.3.x milestone Jul 1, 2021
@carmocca
Copy link
Contributor Author

carmocca commented Jul 1, 2021 •
edited
Loading

#8116 might have fixed the ones marked as "flaky test". Need to check if that's the case but I'm sure the rest are still failing

#6208 might also fix or help here. Will check once that is merged

@stale
Copy link

stale bot commented Jul 31, 2021

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Jul 31, 2021
@carmocca carmocca mentioned this issue Aug 2, 2021
Merged
9 tasks
@stale stale bot removed the won't fix This will not be worked on label Aug 2, 2021
@stale
Copy link

stale bot commented Sep 3, 2021

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Sep 3, 2021
@stale stale bot closed this as completed Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3rd party Related to a 3rd-party bug Something isn't working ci Continuous Integration help wanted Open to be worked on priority: 1 Medium priority task won't fix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Multi-GPU join for horovod irasit/pytorch-lightning
3 participants
@Borda @carmocca @edenlightning