Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/Features for step-based models #827

Closed
srush opened this issue Feb 12, 2020 · 4 comments
Closed

Support/Features for step-based models #827

srush opened this issue Feb 12, 2020 · 4 comments
Labels
bug Something isn't working feature Is an improvement or enhancement help wanted Open to be worked on

Comments

@srush
Copy link
Contributor

srush commented Feb 12, 2020

🐛 Bug+Feature

For models like transformer, we utilize step-based learning rates and evaluation.

It would be nice to have several features along this line.

  1. Support for step-based schedulers. Right now we use cannot give the scheduler to lightning, because it calls scheduler.step(epochs=epoch) internally which resets the scheduler.

  2. Fix docs for step based evaluation and checkpointing. It seems like it exists but it is hard to tell which is epochs / steps.

  3. Add a max_steps option for stopping training.

  4. Helper functions for converting between steps and epochs. For instance, from the number of epochs and parallelism, get the steps for configure_optimizers

@srush srush added the bug Something isn't working label Feb 12, 2020
@peteriz
Copy link

peteriz commented Feb 13, 2020

Hi @srush
For 1. I have opened issue #806 to discuss about it and I will contribute this soon.
For 3. I added PR #728 that adds max/min steps for training such models.

@Borda Borda added feature Is an improvement or enhancement help wanted Open to be worked on labels Feb 20, 2020
@Borda
Copy link
Member

Borda commented Feb 20, 2020

@srush good suggestions, would you mind to send a PR for 2 and 4?

@williamFalcon
Copy link
Contributor

we just merged a pr #728 about this

@Borda
Copy link
Member

Borda commented Mar 30, 2020

feel free to reopen if needed 🤖

@Borda Borda closed this as completed Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Development

No branches or pull requests

4 participants