Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deepspeed requirement from <0.6.0 to <0.7.0 in /requirements #13048

Merged
merged 2 commits into from
May 27, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 12, 2022

Updates the requirements on deepspeed to permit the latest version.

Release notes

Sourced from deepspeed's releases.

v0.6.4: Patch release

What's Changed

New Contributors

Full Changelog: microsoft/DeepSpeed@v0.6.3...v0.6.4

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

cc @Borda @carmocca @akihironitta

Updates the requirements on [deepspeed](https://github.com/microsoft/DeepSpeed) to permit the latest version.
- [Release notes](https://github.com/microsoft/DeepSpeed/releases)
- [Commits](microsoft/DeepSpeed@v0.1.0...v0.6.4)

---
updated-dependencies:
- dependency-name: deepspeed
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the ci Continuous Integration label May 12, 2022
@dependabot dependabot bot requested a review from a team May 12, 2022 13:15
@mergify mergify bot added the ready PRs ready to be merged label May 23, 2022
@Borda Borda added this to the 1.7 milestone May 24, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 27, 2022

A newer version of deepspeed exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐰

@Borda Borda merged commit e19babc into master May 27, 2022
@Borda Borda deleted the dependabot-pip-requirements-deepspeed-lt-0.7.0 branch May 27, 2022 15:54
@carmocca
Copy link
Contributor

This broke CI because DeepSpeed 0.6.5 produces the error described in #13177 (comment).

And Dependabot is useless until the docker images are refreshed and used before merging the dependabot PRs, because the CI for this PR still used deepspeed==0.5.10 since it is what was available in the docker image. For these updates to be reliable, CI for the PR needs to run with the updated version.

This change needs to be reverted. Will do it in #13177

carmocca added a commit that referenced this pull request May 31, 2022
carmocca added a commit that referenced this pull request May 31, 2022
@awaelchli
Copy link
Contributor

@carmocca just saw the comment about Lite. Yes there must be change in the init wrapper logic in deepspeed that broke the getattr logic I wrote for the LiteModule. You can assign me to the issue.

carmocca added a commit that referenced this pull request May 31, 2022
carmocca pushed a commit that referenced this pull request May 31, 2022
…13048)

* Update deepspeed requirement from <0.6.0 to <0.7.0 in /requirements

Updates the requirements on [deepspeed](https://github.com/microsoft/DeepSpeed) to permit the latest version.
- [Release notes](https://github.com/microsoft/DeepSpeed/releases)
- [Commits](microsoft/DeepSpeed@v0.1.0...v0.6.4)

---
updated-dependencies:
- dependency-name: deepspeed
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
carmocca added a commit that referenced this pull request May 31, 2022
carmocca pushed a commit that referenced this pull request May 31, 2022
…13048)

* Update deepspeed requirement from <0.6.0 to <0.7.0 in /requirements

Updates the requirements on [deepspeed](https://github.com/microsoft/DeepSpeed) to permit the latest version.
- [Release notes](https://github.com/microsoft/DeepSpeed/releases)
- [Commits](microsoft/DeepSpeed@v0.1.0...v0.6.4)

---
updated-dependencies:
- dependency-name: deepspeed
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
carmocca added a commit that referenced this pull request May 31, 2022
@carmocca carmocca mentioned this pull request Jun 1, 2022
8 tasks
lexierule pushed a commit that referenced this pull request Jun 1, 2022
…13048)

* Update deepspeed requirement from <0.6.0 to <0.7.0 in /requirements

Updates the requirements on [deepspeed](https://github.com/microsoft/DeepSpeed) to permit the latest version.
- [Release notes](https://github.com/microsoft/DeepSpeed/releases)
- [Commits](microsoft/DeepSpeed@v0.1.0...v0.6.4)

---
updated-dependencies:
- dependency-name: deepspeed
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
lexierule pushed a commit that referenced this pull request Jun 1, 2022
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants