Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Remove simple test ci_test-base.yml #13250

Merged
merged 5 commits into from
Jun 8, 2022
Merged

CI: Remove simple test ci_test-base.yml #13250

merged 5 commits into from
Jun 8, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jun 8, 2022 •
edited by github-actions bot
Loading

What does this PR do?

I'd like to suggest removing the workflow completely for maintainability. It also saves a few hundred MiB of cache size limit (10GB per repo).

What the workflow does

All it does is basically measuring the code coverage over pytorch_lightning by running pytest pytorch_lightning.

coverage run --source pytorch_lightning -m pytest pytorch_lightning -v

Questions

This doesn't make any sense to me, and if it does to you, I'd love to hear your answers to the following questions:

  1. Why do we need to measure codecov here while we already do in ci_test-full.yml. To me, it looks like a complete duplicate.
    https://github.com/PyTorchLightning/pytorch-lightning/blob/83436ee3dfd0d4079e0f8e704ba76aca672af19d/.github/workflows/ci_test-full.yml#L132
    Mind that it runs pytest pytorch_lightning above ⬆️.
  2. Why do we run pytest pytorch_lightning to measure codecov in the first place? As far as I understand, pytest pytorch_lightning runs only doctests but doesn't run any actual tests. Is the codecov result from running doctests useful
    really?

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [RFC] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃 🪨 🚀

cc @Borda @carmocca @akihironitta

@akihironitta akihironitta added the ci Continuous Integration label Jun 8, 2022
carmocca
carmocca approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the CI documentation

@mergify mergify bot added the ready PRs ready to be merged label Jun 8, 2022
@mergify mergify bot requested a review from a team June 8, 2022 11:22
@carmocca carmocca added this to the 1.6.x milestone Jun 8, 2022
@carmocca
Copy link
Contributor

carmocca commented Jun 8, 2022

This requires that an admin disables the "source (ubuntu-20.04, 3.9)" required check. Ping us about it when GPU ci is working again

@Borda
Copy link
Member

Borda commented Jun 8, 2022

Ok, let's as part of the PR move this simple testing so if there is an issue it fails fast

@Borda Borda requested review from carmocca and Borda June 8, 2022 11:41
@mergify mergify bot requested a review from a team June 8, 2022 15:07
@Borda Borda changed the title [RFC][CI] Remove simple test ci_test-base.yml CI: Remove simple test ci_test-base.yml Jun 8, 2022
@mergify mergify bot requested a review from a team June 8, 2022 15:10
@Borda Borda changed the base branch from master to future/structure June 8, 2022 16:45
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 8, 2022
@Borda Borda changed the base branch from future/structure to master June 8, 2022 18:04
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 8, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jun 8, 2022
@lexierule lexierule merged commit 56cd883 into master Jun 8, 2022
@lexierule lexierule deleted the ci/rm-base branch June 8, 2022 18:36
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
rohitgr7 pushed a commit that referenced this pull request Jul 1, 2022
@akihironitta @rohitgr7
Merge pull request #13250 from PyTorchLightning/ci/rm-base
96d1f92 
CI: Remove simple test `ci_test-base.yml`
lexierule pushed a commit that referenced this pull request Jul 12, 2022
@rohitgr7 @Borda
@akihironitta @carmocca @dependabot @adamjstewart @awaelchli @martinosorb
Weekly patch release v1.6.5 (#13481)
ff53616 
* update NGC docker (#13136)

* update docker
* Apply suggestions from code review

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Decouple pulling legacy checkpoints from existing GHA workflows and docker files (#13185)

* Add pull-legacy-checkpoints action
* Replace pulls with the new action and script
* Simplify

* Merge pull request #13250 from PyTorchLightning/ci/rm-base

CI: Remove simple test `ci_test-base.yml`

* Update rich requirement from !=10.15.*,<=12.0.0,>=10.2.2 to >=10.2.2,!=10.15.0.a,<13.0.0 in /requirements (#13047)

* Update rich requirement in /requirements

Updates the requirements on [rich](https://github.com/willmcgugan/rich) to permit the latest version.
- [Release notes](https://github.com/willmcgugan/rich/releases)
- [Changelog](https://github.com/Textualize/rich/blob/master/CHANGELOG.md)
- [Commits](Textualize/rich@v10.2.2...v12.4.1)

---
updated-dependencies:
- dependency-name: rich
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix torch.distributed._sharded_tensor DeprecationWarning (#13261)

* update tutorials (#13268)

* [BUG] `estimated_stepping_batches` requires distributed comms in `configure_optimizers` for `DeepSpeedStrategy` (#13350)

* Update torchmetrics requirement from <=0.7.2,>=0.4.1 to >=0.4.1,<0.9.2 in /requirements (#13275)

Update torchmetrics requirement in /requirements

Updates the requirements on [torchmetrics](https://github.com/PyTorchLightning/metrics) to permit the latest version.
- [Release notes](https://github.com/PyTorchLightning/metrics/releases)
- [Changelog](https://github.com/PyTorchLightning/metrics/blob/master/CHANGELOG.md)
- [Commits](Lightning-AI/torchmetrics@v0.4.1...v0.9.1)

---
updated-dependencies:
- dependency-name: torchmetrics
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix mypy errors for model summary utilities (#13384)

* rename org Lightning AI

* Modified python version check to accommodate for legacy version styles (#13420)

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit b332b66)

* Call `set_epoch` for distributed batch samplers (#13396)

Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

(cherry picked from commit 2dd332f)

* _RICH_AVAILABLE

* _FAIRSCALE_AVAILABLE

* _BAGUA_AVAILABLE

* redefine

* chlog spaces

* CI: Fix `fatal: unsafe repository` (#13515)

* update release date

* CI: azure rename

* Restore log step during restart (#13467)

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* remove redundant test

* Update CI setup (#13291)

* drop mamba
* use legacy GPU machines

* fix schema check

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Co-authored-by: Sean Naren <sean@grid.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Martino Sorbaro <martinosorb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@tchaton tchaton Awaiting requested review from tchaton

Assignees
No one assigned
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.
4 participants
@akihironitta @carmocca @Borda @lexierule