Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual backward for DeepSpeed #13882

Merged
merged 13 commits into from
Jul 27, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 27, 2022

What does this PR do?

WIP

Needed for #13859

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @awaelchli @rohitgr7 @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 27, 2022
@awaelchli awaelchli added bug Something isn't working strategy: deepspeed labels Jul 27, 2022
@awaelchli awaelchli added this to the pl:1.6.x milestone Jul 27, 2022
@carmocca carmocca changed the base branch from master to tests/update-deepspeed-lite July 27, 2022 15:53
tests/tests_pytorch/lite/test_lite.py Outdated Show resolved Hide resolved
tests/tests_pytorch/lite/test_lite.py Outdated Show resolved Hide resolved
@carmocca carmocca marked this pull request as ready for review July 27, 2022 16:09
@carmocca carmocca merged commit fe9803c into tests/update-deepspeed-lite Jul 27, 2022
@carmocca carmocca deleted the bugfix/deepspeed-manual-backward branch July 27, 2022 16:09
@carmocca carmocca removed this from the pl:1.6.x milestone Jul 27, 2022
@awaelchli awaelchli added this to the pl:1.7 milestone Aug 1, 2022
@mergify mergify bot added the has conflicts label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working has conflicts pl Generic label for PyTorch Lightning package strategy: deepspeed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants