-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docstrings for backward methods #13886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
awaelchli
requested review from
tchaton,
justusschock and
kaushikb11
as code owners
July 27, 2022 17:10
rohitgr7
approved these changes
Jul 27, 2022
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
for more information, see https://pre-commit.ci
…ocs/backward-docstrings
Borda
approved these changes
Jul 28, 2022
carmocca
approved these changes
Jul 28, 2022
kaushikb11
approved these changes
Jul 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #13886 +/- ##
=========================================
+ Coverage 61% 76% +14%
=========================================
Files 332 343 +11
Lines 26078 27311 +1233
=========================================
+ Hits 15939 20647 +4708
+ Misses 10139 6664 -3475 |
akihironitta
approved these changes
Jul 29, 2022
tchaton
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Co-authored-by: thomas chaton <thomas@grid.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Documentation related
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
strategy: deepspeed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After recent changes in #13863, I forgot to update the docstrings.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @rohitgr7 @awaelchli @akihironitta