Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call optimizer.zero_grad() before backward inside closure in AutoOpt #6147

Merged
merged 37 commits into from
Mar 1, 2021
Merged

Call optimizer.zero_grad() before backward inside closure in AutoOpt #6147

merged 37 commits into from
Mar 1, 2021

Commits on Feb 23, 2021

  1. Call zero_grad inside closure

    @akihironitta
    akihironitta committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    a6da028 View commit details
    Browse the repository at this point in the history

  2. Call zero_grad inside closure independently of optim

    @akihironitta
    akihironitta committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    57840f9 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Remove optimizer.zero_grad from optimizer.step

    @akihironitta
    akihironitta committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    8d1253d View commit details
    Browse the repository at this point in the history

  2. Use accelerator's zero_grad

    @akihironitta
    akihironitta committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    eaf42fd View commit details
    Browse the repository at this point in the history

  3. Update manual optimization docs

    @akihironitta
    akihironitta committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    00376fc View commit details
    Browse the repository at this point in the history

  4. Update automatic optimization docs

    @akihironitta
    akihironitta committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    be43077 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into bugfix/4083_lbfgs

    @akihironitta
    akihironitta committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    77d7f83 View commit details
    Browse the repository at this point in the history

  6. Update new-project docs

    @akihironitta
    akihironitta committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    3f6e086 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Move on_before_zero_grad to trainloop

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    c422ffa View commit details
    Browse the repository at this point in the history

  2. Use trainerloop methods

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    95e0a0b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'bugfix/4083_lbfgs' of github.com:akihironitta/pytorch-l… 

    …ightning into bugfix/4083_lbfgs
    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    e852efd View commit details
    Browse the repository at this point in the history

  4. Remove zero_grad after backward

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    8243b80 View commit details
    Browse the repository at this point in the history

  5. Split tests to step and zero_grad

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    8269f45 View commit details
    Browse the repository at this point in the history

  6. Call zero_grad before backward in tests

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    4694e3e View commit details
    Browse the repository at this point in the history

  7. Call zero_grad before backward in tests

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    d658920 View commit details
    Browse the repository at this point in the history

  8. Add a test for optimization with lbfgs

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    2dd6154 View commit details
    Browse the repository at this point in the history

  9. Remove unused model

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    2fe4d28 View commit details
    Browse the repository at this point in the history

  10. Add back BoringModel

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    1845a67 View commit details
    Browse the repository at this point in the history

  11. Update CHANGELOG

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    eb875b4 View commit details
    Browse the repository at this point in the history

  12. zero_grad when the first batch of accumulation

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    d898e7b View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into bugfix/4083_lbfgs

    @akihironitta
    akihironitta committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    d262546 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Refactor tests. Remove duplicates

    @carmocca
    carmocca committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    435a3c8 View commit details
    Browse the repository at this point in the history

  2. Add a test to check zero_grad call order

    @akihironitta
    akihironitta committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    22fd399 View commit details
    Browse the repository at this point in the history

  3. flake8

    @akihironitta
    akihironitta committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    02ec3aa View commit details
    Browse the repository at this point in the history

  4. Update test comment

    @akihironitta
    akihironitta committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    f92f708 View commit details
    Browse the repository at this point in the history

  5. Make test compatible with PT1.4

    @akihironitta
    akihironitta committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    85431ff View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
    @akihironitta @carmocca
    akihironitta and carmocca committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    1be883e View commit details
    Browse the repository at this point in the history

  7. Use simple string for logging called methods

    @akihironitta
    akihironitta committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    337d85b View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2021

  1. Add optimzer.step to test

    @akihironitta
    akihironitta committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    3194bb3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bugfix/4083_lbfgs

    @akihironitta
    akihironitta committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    1b5c1ce View commit details
    Browse the repository at this point in the history

  3. Update the test comment

    @akihironitta
    akihironitta committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    91e7ae1 View commit details
    Browse the repository at this point in the history

  4. Update the test

    @akihironitta
    akihironitta committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    96a5504 View commit details
    Browse the repository at this point in the history

  5. Update the test

    @akihironitta
    akihironitta committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    87fdfb8 View commit details
    Browse the repository at this point in the history

  6. Remove unused import

    @akihironitta
    akihironitta committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    9d11f34 View commit details
    Browse the repository at this point in the history

  7. Update test comment

    @akihironitta
    akihironitta committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    93d3f57 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2021

  1. Update CHANGELOG.md

    @akihironitta
    akihironitta committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    05c28d5 View commit details
    Browse the repository at this point in the history

  2. Update docs

    @akihironitta
    akihironitta committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    9836bb7 View commit details
    Browse the repository at this point in the history