Cherry-picking 1.2.1 release [full merge, no squash] #6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* precision fixes * add amp test model * fix test * revert * move assert to training step * fix test * fix test * remove unrelated changes * add changelog * remove unused import
…accelerator (#6089) * Give priority to plugins to set distributed mode, and then accelerator * Add CHANGELOG.md * Update CHANGELOG.md * Remove very scary line * Ensure we set cluster environment after slurm configured if necessary * Simplify the fix with a reset Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* fix weird test * fix apex plugin test * fix raise * cpu test * fix type * add changelog
carmocca
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## release/1.2.x #6154 +/- ##
==============================================
- Coverage 93% 91% -2%
==============================================
Files 160 160
Lines 11402 11402
==============================================
- Hits 10654 10412 -242
- Misses 748 990 +242 |
SeanNaren
approved these changes
Feb 23, 2021
|
The issue is that as we cherry-pick specific commits from master, we don't have all CHANGELOG changes. I'll open a PR to master copying the 1.2.1 section so we don't do them all at once when 1.3 arrives |
8 tasks
Borda
changed the title
Borda
approved these changes
Feb 23, 2021
rohitgr7
approved these changes
Feb 23, 2021
awaelchli
approved these changes
Feb 23, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title