Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify deprecations #6620

Merged
merged 11 commits into from
Mar 25, 2021
Merged

Simplify deprecations #6620

merged 11 commits into from
Mar 25, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 21, 2021

What does this PR do?

  • Use an external package - pyDepracate with zero dependencies
  • Define deprecate utility to re-use common arguments for metrics

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@Borda Borda added the ready PRs ready to be merged label Mar 22, 2021
@Borda Borda requested a review from a team March 22, 2021 19:50
@carmocca carmocca disabled auto-merge March 22, 2021 21:24
@Borda Borda requested a review from rohitgr7 March 23, 2021 21:07
@mergify mergify bot removed the has conflicts label Mar 24, 2021
@Borda Borda enabled auto-merge (squash) March 24, 2021 08:30
@Borda Borda requested review from a team March 24, 2021 08:58
@carmocca carmocca removed the Will label Mar 25, 2021
@Borda Borda merged commit 217c12a into master Mar 25, 2021
@Borda Borda deleted the refactor/deprecate branch March 25, 2021 14:26
@carmocca carmocca added this to the 1.3 milestone Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants