Weekly Patch Release v.1.2.5 [full merge, no squash] #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
force-pushed
the
v1.2.5
branch
2 times, most recently
from
13b2113
to
b762fb4
Compare
Borda
force-pushed
the
v1.2.5
branch
2 times, most recently
from
40d952c
to
caebaea
Compare
|
the same error as in #6536 (comment) |
Borda
force-pushed
the
v1.2.5
branch
4 times, most recently
from
13e7c2c
to
c3be721
Compare
Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> (cherry picked from commit bc577ca)
* update doc * update example (cherry picked from commit 8853a36)
(cherry picked from commit 983a888)
(cherry picked from commit 87c03b1)
* try Azure * -e * path (cherry picked from commit cb59039)
* refactoring setup * . * docs * flake8 (cherry picked from commit 1fae10a)
* fix comparing versions * chlog * . * ... * datasets (cherry picked from commit 8cd75a4)
* Add Tests for val and test-steps * Add native AMP * pep8 tests * pep8 plugin * changelog (cherry picked from commit 634d831)
Borda
requested review from
ananyahjha93,
awaelchli,
carmocca,
edenlightning,
justusschock,
SeanNaren and
SkafteNicki
as code owners
Borda
requested review from
tchaton,
teddykoker and
williamFalcon
as code owners
Borda
force-pushed
the
v1.2.5
branch
2 times, most recently
from
273cf64
to
d492cd8
Compare
kaushikb11
approved these changes
Mar 24, 2021
ananthsub
approved these changes
Mar 24, 2021
|
missing #6536 as the test does not pass, probably needs some other commit |
Borda
commented
Mar 24, 2021
Comment on lines
+2
to
+6
| from torchmetrics import Metric as TMetric | ||
|
|
||
| from pytorch_lightning import Trainer | ||
| from pytorch_lightning.metrics import Metric, MetricCollection | ||
| from pytorch_lightning.metrics import Metric as PLMetric | ||
| from pytorch_lightning.metrics import MetricCollection |
There was a problem hiding this comment.
@tchaton van you pls double check that this is sufficient compatibility test for PL and TM metrics
Closed
carmocca
reviewed
Mar 24, 2021
* base class * extensions * chlog * _stable_1d_sort * _check_same_shape * _input_format_classification_one_hot * utils * to_onehot * select_topk * to_categorical * get_num_classes * reduce * class_reduce * tests (cherry picked from commit 6453091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refers to #6083
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃