Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profilers - do not write when there's no summary #6681

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Mar 26, 2021

What does this PR do?

Avoids PassThroughProfiler printing empty logs whenever describe is called. This happens because its summary fn returns an empty string. This PR avoids logging in that case.

No need for CHANGELOG update as this bug is unreleased.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the bug Something isn't working label Mar 26, 2021
@carmocca carmocca added this to the 1.3 milestone Mar 26, 2021
@carmocca carmocca self-assigned this Mar 26, 2021
@carmocca carmocca changed the title Profilers - do not describe when there's no summary Profilers - do not write when there's no summary Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #6681 (7b2a13c) into master (0ea8f39) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6681    +/-   ##
=======================================
- Coverage      91%     87%    -4%     
=======================================
  Files         192     192            
  Lines       12266   12301    +35     
=======================================
- Hits        11178   10677   -501     
- Misses       1088    1624   +536     

@carmocca carmocca added priority: 0 High priority task ready PRs ready to be merged labels Mar 26, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot requested a review from a team March 26, 2021 11:37
@SeanNaren SeanNaren merged commit b730a5a into master Mar 26, 2021
@SeanNaren SeanNaren deleted the fix-passthrough-describe branch March 26, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants