Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoding of rank_zero_only.rank in accelerator connector #6878

Merged
merged 3 commits into from
Apr 8, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Apr 7, 2021

What does this PR do?

After #6802 this shouldn't be necessary. rank_zero_only populates based on environment variables. With this code around, it risks overriding the cluster environment variables.

Continuation of fixing #6797

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub added this to the 1.2.x milestone Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #6878 (0f0fd67) into master (19e67d1) will decrease coverage by 4%.
The diff coverage is n/a.

❗ Current head 0f0fd67 differs from pull request most recent head aeb3268. Consider uploading reports for the commit aeb3268 to get more accurate results

@@           Coverage Diff           @@
##           master   #6878    +/-   ##
=======================================
- Coverage      91%     87%    -4%     
=======================================
  Files         193     193            
  Lines       12299   12297     -2     
=======================================
- Hits        11252   10703   -549     
- Misses       1047    1594   +547     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kaushikb11 kaushikb11 merged commit 968ac09 into Lightning-AI:master Apr 8, 2021
@SeanNaren SeanNaren mentioned this pull request Apr 12, 2021
SeanNaren pushed a commit that referenced this pull request Apr 13, 2021
lexierule pushed a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants